fbp93
commented
1 week ago I also checked and it's breaking starting from 0.74.0
Open fbp93 opened 1 week ago
fbp93
commented
1 week ago I also checked and it's breaking starting from 0.74.0
fbp93
commented
3 days ago @cipolleschi can you have a look when you have some time? thanks 🙏
max-quirk
commented
2 days ago Also getting this issue :'(
cipolleschi
commented
1 day ago Looking into it. We probably make a mistake in configuring the RCTDeprecation podspec.
cipolleschi
commented
1 day ago @fbp93 I tried the app and the main target builds fine with static libraries and static frameworks.
AudioManager fails, but it fails because React/RCTBridgeModule.h' file not found, not RCTDeprecation not found
I think that the problem is in the header search paths. If you look at the search paths for the main project, they look like this:
The header search paths of the AudioManager looks like this:
The structure of React-Core on disk is like this:
And, as you can see, there is no folder called Public after Headers.
This type of setup, anyway, is not something we recommend: it would be better to create a proper pod for an external library, to benefit from all the automations we are building for autolinking.
That said, @fbp93 and @max-quirk, if you can provide a reproducer where I can see the RCTDeprecation.h file not found happen, I'll be glad to dig into it more closely!
fbp93
commented
12 hours ago And, as you can see, there is no folder called Public after Headers.
@cipolleschi Shouldn't the header search path link to the headers in the pods? Because there I see the public folder. Have you been able to make the audio manager build by that change ? 🤔
This type of setup, anyway, is not something we recommend: it would be better to create a proper pod for an external library, to benefit from all the automations we are building for autolinking.
Unfortunatly I have a lots of them with the current setup, so it's not something I was plan to do immediatly, but I'll definitely consider it
cipolleschi
commented
7 hours ago Shouldn't the header search path link to the headers in the pods?
nope, because with frameworks, the items that are copied to the bundle and used for linking are the content of the .framework folder.
Have you been able to make the audio manager build by that change ?
Unfortunately not, once I saw that the setup was not standard and the error was different, I stopped. I think we should first understand why we are seeing two different errors.
Unfortunatly I have a lots of them with the current setup, so it's not something I was plan to do immediatly, but I'll definitely consider it
😞 But I understand. Working with legacy projects is tough. I'm going to be on PTO next week, but I plan to resume the work on this when I'm back.
fbp93
commented
6 hours ago nope, because with frameworks, the items that are copied to the bundle and used for linking are the content of the .framework folder.
the weird thing is that the same setup was working fine with the previous react and even if I try to remove the public it's not working anyway 🤔
Unfortunately not, once I saw that the setup was not standard and the error was different, I stopped. I think we should first understand why we are seeing two different errors.
Actually it seems that sometimes I get your same error and sometimes the RCTDeprecation one, so I think it's kind of related. Probably if we are able to make it build we may fix both or understand more 🤔
Description
I'm trying to bump my project to React Native 0.74.2, but iOS is failing to compile due to the following issue:
This is happening only when I try to link a static library to my project which contains some object C code that imports React native. I reproduced the issue on a template project and tested with different versions:
Steps to reproduce
Perform the following commands:
React Native Version
0.74.2
Affected Platforms
Other (please specify)
Output of
npx react-native infoStacktrace or Logs
Reproducer
https://github.com/fbp93/RN-0.74.2
Screenshots and Videos
No response