facebook / react-native

A framework for building native applications using React
https://reactnative.dev
MIT License
117.1k stars 24.07k forks source link

The TextInput's showSoftInputOnFocus prop is causing unnecessary events to be triggered. #45106

Open nkubatyi opened 2 weeks ago

nkubatyi commented 2 weeks ago

Description

I'm encountering an issue with the TextInput component in React Native when using the showSoftInputOnFocus prop. When the TextInput gains focus, the keyboard does not open, the keyboardWillShow and keyboardDidShow events are not triggered. However, upon losing focus, the keyboardWillHide and keyboardDidHide events are fired.

This behavior causes problems with Keyboard Aware components that listen for these events.

Steps to reproduce

  1. Create a new React Native project.
  2. Add a TextInput component with the showSoftInputOnFocus prop set to false.
  3. Add event listeners for keyboardWillShow, keyboardDidShow, keyboardWillHide, and keyboardDidHide events.
  4. Focus on the TextInput and observe that keyboardWillShow and keyboardDidShow events are not triggered.
  5. Blur the TextInput and observe that keyboardWillHide and keyboardDidHide events are triggered.

React Native Version

0.72.9

Affected Platforms

Runtime - iOS

Output of npx react-native info

System:
  OS: macOS 14.2.1
  CPU: (8) arm64 Apple M1 Pro
  Memory: 140.09 MB / 16.00 GB
  Shell:
    version: 3.2.57
    path: /bin/bash
Binaries:
  Node:
    version: 18.18.2
    path: ~/miniconda3/bin/node
  Yarn:
    version: 1.22.19
    path: /usr/local/bin/yarn
  npm:
    version: 9.8.1
    path: ~/miniconda3/bin/npm
  Watchman: Not Found
Managers:
  CocoaPods:
    version: 1.13.0
    path: /usr/local/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.0
      - iOS 17.0
      - macOS 14.0
      - tvOS 17.0
      - watchOS 10.0
  Android SDK:
    API Levels:
      - "32"
      - "33"
      - "33"
    Build Tools:
      - 30.0.3
      - 33.0.0
      - 33.0.2
    System Images:
      - android-33 | Google APIs ARM 64 v8a
      - android-33 | Google APIs Intel x86_64 Atom
      - android-33 | Google Play ARM 64 v8a
    Android NDK: Not Found
IDEs:
  Android Studio: 2022.1 AI-221.6008.13.2211.9619390
  Xcode:
    version: 15.0/15A240d
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 18.0.2.1
    path: /usr/bin/javac
  Ruby:
    version: 2.6.10
    path: /usr/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.72.9
    wanted: 0.72.9
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: Not found
  newArchEnabled: Not found
iOS:
  hermesEnabled: Not found
  newArchEnabled: Not found

Stacktrace or Logs

There is no crash.

Reproducer

https://snack.expo.dev/@kubatyi.dev/692c3c

Screenshots and Videos

No response

github-actions[bot] commented 2 weeks ago
:warning: Newer Version of React Native is Available!
:information_source: You are on a supported minor version, but it looks like there's a newer patch available - 0.72.15. Please upgrade to the highest patch for your minor or latest and verify if the issue persists (alternatively, create a new project and repro the issue in it). If it does not repro, please let us know so we can close out this issue. This helps us ensure we are looking at issues that still exist in the most recent releases.
shubhamguptadream11 commented 2 days ago

As per the above repro provided. I am seeing keyboardWillHide keyboardDidHide events on focus of TextInput with showSoftInputOnFocus as false. As per your problem statement it's called when we blur the TextInput. @nkubatyi Can you confirm once on this.