Open fbp93 opened 3 days ago
@cipolleschi 🙏
@fbp93 thanks for the issue. IIUC, this got broken in 0.73, right? From which version did you migrate?
To set expectation, this might take a while for us, given that 73 is almost going out of the support window and we almost released already 3 major versions.
@fbp93 thanks for the issue. IIUC, this got broken in 0.73, right? From which version did you migrate?
To set expectation, this might take a while for us, given that 73 is almost going out of the support window and we almost released already 3 major versions.
I'm moving from 0.71.16 to 0.75.4. I tested different versions and I found out that the issue started to happen in 0.73.0 (the 0.72.17 is working fine).
To set expectation, this might take a while for us, given that 73 is almost going out of the support window and we almost released already 3 major versions.
@cipolleschi Even if the issue started in 0.73 it's still happening in 0.75 (I didn't tested 0.76 yet). Do you think it's gonna take a while even if it's still a bug in the latest release?
Yes, probably. We are currently a bit swamped for 0.76 and having to investigate when this happened and how to properly fix this might take a while. Unless you guys had some time to look at what changed between 0.72 and 0.73 in the Image component.
Also, is this happening on both architecture or only on the Old Architecture?
Unless you guys had some time to look at what changed between 0.72 and 0.73 in the Image component.
I'm checking all files here but I don't see major changes 🤔 Is there any other place where I should have a look related to the image component?
Also, is this happening on both architecture or only on the Old Architecture?
i m currently testing on the old architecture
I'm checking all files here but I don't see major changes 🤔 Is there any other place where I should have a look related to the image component?
I don't think.. But you can also debug what's happening in the RCTImageLoader
! Breakpoints works great in Xcode.
i m currently testing on the old architecture
If you create a reproducer with this template, could you test also onn the New Architecture, please?
@cipolleschi Also, is there a way to install a specific commit of RN? I wanna find where it started to break, I'm trying with
"dependencies": {
"react-native": "git+https://github.com/facebook/react-native.git#1eb4bf0d3af1fe267f5de6bf4bbe1e65d41fea1b",
but packages are not installed correctly so the pod install doesn't work.
no, it's not possible easily. You should package react-native as a proper NPM package. Your best approximation is using nightlies
I tried a bit but it's hard without testing the single commits and having some context. Considering I'm planning to ship this in around 1 month, do you think will there any chance that any of you will have some time to have a look in this timeframe or do you think you ll be busy for more time? Just to understand how much effort or alternative I should put on this. 🙏
Description
My app is downloading differente pngs saving them without an explicit extension in order to show them later through the
<Image />
react native component(you can find an example here). This was working fine, but starting from React 0.73.0 the image is not displayed correctly. Adding an explicit extension to the file (e.g. manually adding the .png) seems fixing it, but my app have several images already downloaded so it's not so easy to handle existing users. IMO it's still an unwanted issue that should be fixed considering it's a breaking change.Steps to reproduce
path
var in App.tsx with the path of the directoryReact Native Version
0.75.4
Affected Platforms
Runtime - iOS
Output of
npx react-native info
Stacktrace or Logs
Reproducer
https://github.com/fbp93/RN75/tree/master
Screenshots and Videos
No response