search

facebook / react-native

A framework for building native applications using React
https://reactnative.dev
MIT License
119.28k stars 24.35k forks source link

fix `r` & `d` not working from Metro sometimes #47624

Closed EdmondChuiHW closed 2 days ago

EdmondChuiHW commented 2 days ago

Summary: Changelog: [iOS][Fixed] - fix r & d not working from Metro sometimes

While investigating these bugs, I've come across some cases where r (Reload) & d (Open Dev Menu) not working in Metro.

This is because when we

  1. Start app without Metro
  2. Start Metro
  3. Reload from Dev Menu (rage shake)

RCTPackagerConnection did not get notified about the change in bundle URL. It'd stay "listening" to the commands from the local bundle instead of Metro .

Differential Revision: D65973309

facebook-github-bot commented 2 days ago

This pull request was exported from Phabricator. Differential Revision: D65973309

facebook-github-bot commented 2 days ago

This pull request has been merged in facebook/react-native@9a60038a40e16925ea1adeb3e3c937c22a615485.

react-native-bot commented 2 days ago

This pull request was successfully merged by @EdmondChuiHW in 9a60038a40e16925ea1adeb3e3c937c22a615485

When will my fix make it into a release? | How to file a pick request?