TouchableNativeFeedback's ripples aren't affected by borderRadius on Android 9

facebook / react-native

A framework for building native applications using React

https://reactnative.dev

MIT License

119.2k stars 24.33k forks source link

TouchableNativeFeedback's ripples aren't affected by borderRadius on Android 9 #6480

Closed jeffchienzabinet closed 3 years ago

jeffchienzabinet commented 8 years ago

This is a bit of a problem when creating buttons with borderRadius and TouchableNativeFeedback, and the ripples extend out. I'm not an expert but I suppose setNativeBackground needs to get the corner radius when making the mask for the RippleDrawable and setBorderRadius may need to remake the background drawable somehow.