facebook / react-native

A framework for building native applications using React
https://reactnative.dev
MIT License
118.84k stars 24.29k forks source link

[0.22] JSX Bundle Hosting Issues on Linux Server #6581

Closed daesan closed 8 years ago

daesan commented 8 years ago

I am hosting JSX bundle on the linux server so that my teammates can test the latest version of the app I am working on.

Up until RN 0.21 I had no problem. However, starting with RN 0.22 I am getting the following error on XCode when my app starts and tries to fetch the jsx bundle from the server.

3240fc88-eed7-11e5-8dc4-57fcc040bf7c

On the debugging console, I have following values.

URL NSURL * @"http://app.xyz.com:(null)/message?role=shell" 0x000000015f53f690 cookies NSURL * @"http://app.xyz.com:(null)/message?role=shell" 0x000000015f53f690

Looking at the server console (npm start), HTTP request message to the bundle file is printed only some of the times. I assume that is due to the asynchronous nature of such requests.

Does anybody know why this error is occurring? Could this error be related to the HMR, newly introduced in RN 0.22? Any feedback will be appreciated!

satya164 commented 8 years ago

@facebook-github-bot stack-overflow

facebook-github-bot commented 8 years ago

Hey @daesan and thanks for posting this! @satya164 tells me this issue looks like a question that would be best asked on StackOverflow. StackOverflow is amazing for Q&A: it has a reputation system, voting, the ability to mark a question as answered. Because of the reputation system it is likely the community will see and answer your question there. This also helps us use the GitHub bug tracker for bugs only. Will close this as this is really a question that should be asked on SO.

daesan commented 8 years ago

@satya164 I assume that you closed this issue because you thought this was a question. However, I persist that this is a bug. This is not a configuration issue.

Unless you think JSX bundle serving does not need to be supported on Linux, I believe this issue belongs to Github. Please unclose this issue.

bestander commented 8 years ago

@daesan thanks for being persistent, I think you are right, this does seem like a bug, I'll reopen it. We would appreciate if you could help us finding the reasons why this happens.

Would you want to try building an earlier version between 0.21 and 0.22 and bisect where the break happened? It could take a few hours considering that we have about 300 commits between them but the script to build it should be fairly straight forward.

We'll need to make releases more often to make it easier for the community to find issues like that.

And sorry for a bad experience, GitHub does not give enough tools to manage an open source project. So we try to close issues that look like an environment configuration problem or a feature request, just to keep the real issues number manageable.

daesan commented 8 years ago

@bestander Thanks for reopening this issue!

Sure. I am definitely willing to dig into this issue. However, I am not familiar with the process of building React Native from the source. Could you point me to the document or tutorial explaining how to go about this?

I understand that maintaining a popular project like RN is a lot of pain and appreciate people doing it. Thanks for being responsive. :)

satya164 commented 8 years ago

@daesan You can open the UIExplorer.xproj in XCode and build from there.

daesan commented 8 years ago

@satya164 I checked out 0.21-stable branch. Could you explain me how I can pick individual commits and apply selectively? Is this how I am supposed to do this?

satya164 commented 8 years ago

@daesan This is going to be painful :(

I think you can use git bisect and checkout to older commits by something like a commit for each 20 commits. Then building it. And then identify the offending commits.

daesan commented 8 years ago

@satya164 I have tried to work with "git bisect", but I am having a lot of difficulties.

More of individual commits seem to break the build. And maybe I am just not very familiar with git but there doesn't seem to be a simple way to apply individual commits either.

Do you think this brute force method of finding the offending commit is really the best way to proceed with this issue?

While I am not very familiar with most of the native codes of RN, this seems to be a networking issue. Only difference I can think of between JSX bundle being served on my MacBook and Linux server is that MacBook is accessed via IP address and Linux server is accessed via domain name. Do you think this could be at the core of the issue, maybe?

Or could you identify someone who is more familiar with this part of RN code base?

bestander commented 8 years ago

@daesan, to make your life easier, these are the commits between 0.21 and 0.22

You should be able just to git checkout <hash>.

e163e6d fixed podspec verison generation
2360c99 Revert "Sync CSSLayout: Make 'stretch' aligned children fill cross-axis in containers of undefined size in the cross-axis"
0f7e461 inline `__accept` call so that sourcemaps work
cafbeb0 added shrinkwrap to package
995aa48 revert committed version numbers, confusing for CI npm deployments
09ef2b5 added deployment debugging inf
1228321 Npm publish
31c3b08 getCurrentConnectivity should resolve with object
25496d4 Unbreak HMR listener
4113da7 Update hot reloading dependencies
c5feed4 Update node-haste and replace fast-path with node-haste's version to fix Windows compatibility
9ed6616 [0.22.0-rc] Bump version numbers
10e990f Don't publish shrinkwrap
2fe6716 Added objective-c class/module semantics
82e2038 Link to 'LinuxWindowsSupport.md' at the appropriate commit.
49b2805 Geolocation Accuracy and Cached Location Bug
102a31c Fix RefreshControl layout on screen rotation and consecutive pull to refresh not working properly
aae521f Add ReactCompoundViewGroup interface that allows having both virtual and non-virtual (View) children
d0a26a7 RN: Fix Exponential WebSocket Growth from DevTools
72b274a Removed Parse reference since its service is shutting down
e9c9645 Add issue bot close command and add janicduplessis to the bot whitelist
62788a1 Allows a user to specify an xcode scheme name.
fd3a0ba Play nice with `fetch` after the newest changes that add support for `XMLHttpRequest.response`
33e9e34 Backed out changeset D3012925
f885f53 Backed out D3012969
24c458a Fix JS deallocation on load errors
006907b Initialize bridge on a background queue
7dbba3b Add SoundCloud Pulse to the app showcase
4642733 Add app to showcase with source link
11594b8 Fix navigation in UIExplorer. Use current index instead of fixed valu…
7ff938f underlineColor -> underlineColorAndroid
89a486e Fix: cli.js - use var instead of const
d0356fb Updated the Android Setup with correct SDK package to install.
0252812 WebSocket: call onclose before closing in event of error
4130f11 revert D2839551
fedca59 revert D2971596
b430087 Fixed permalink
cde58a6 Rename dev menu option to Hot Reloading on boths ios and android
d1826dd LayoutAnimation now works on android
081a413 Deleted unnecessary 'use strict' in new project templates
262983f Add note about adding new images
87245b2 Support the scriptURLs observed on Android for asset source resolver
ae11449 in ReactContext, de-reference the Activity in onPause() instead of onHostDestroy()
ebf5842 Fix listener name in NavigationAnimatedView
a340105 Replace "Bad: will fatal" with "Bad: will fail" in Text.md
a6a89fe Fix IllegalStateException crash in WebSocketModule.java
970782d run-android Chose your Term for OSX, and Linux
46422dd Ability to supply product flavor for `react-native run-android` command
2d27cf0 Don't warn when jsSchedulingOverhead is negative
54b6b92 Un-blacklist fbjs
21b7bf4 Fix commit order of operations in Nodes
71e5976 Clean up APIs.
fbef6f6 using a more safe branch of sinopia
d815d1d Move cssVar out of react-native-github
ab61a1f Sanitize lineNumber in launchEditor
ea882b6 Immediate dispatch 0 time timers
8d52567 Run an e2e packager test on CircleCI
f0f1f61 Update PR and issue templates and guidelines
cf8bb75 Add Veggies to the showcase
1e96bcf Added troubleshooting
9199c72 WebWorker: Allow worker script to be loaded from the network in debug builds
d6ded2f Display a warning when using src property for an Image rather than source.
e64987d Fix deadlock in bridge
1caebf1 Add data structure to manage the stack for the legacy navigator.
f5edabf Update Babel/React Dependencies
8a16291 nested emit call in a queue should be handled in FIFO
d5d9c5a Tweak HMR updates order
1b4c23e WebWorkers: Update WebWorker sample to use networking/timers
8c25181 Add onShow callback for RCTModalHostView
44997b4 Skeleton for running Android e2e or a separate packager e2e test
2e4bb53 destroy react instance on background critical memory pressure
4b52d18 support simulating critical memory pressure, even when activity is destroyed
c027f05 add generic memory pressure listener interface
9a3f11d WebWorkers: Convert NetworkingModule to support web workers
532e411 added ArcChat.com Android app to showcase
a48db5c added bestander for notifications of travis ci status changes
c2c71ca "loosing"→"losing" (typo)
e4766b7 WebWorkers: Update Timing module to support web workers
39b399e returned flow check to e2e test
7fb3303 Copy weak reference to callback object when dispatching calls to Java
32dd1fe fixed instrumentation tests crashes in emulator
39409dd another fix
5ffeb97 Back out of D3000972
36f1961 Use flow-bin to typecheck locally, update ESLint to 2.0
6d5f9dd WebWorkers: Allow native modules to be notified when executors are unregistered
1bab7c5 vibration module
d2d00e0 Adding GC Timer Sweeping to Android
dc13115 Dispatch module setup asynchronously to avoid blocking main thread when bridge starts
8f3e5b1 Update usage names of React Native color palette
2708df4 Use `invariant` from fbjs everywhere
854c5dd Simplified Travis configuration
8717b2d Rework the NavigationHeader
eb53194 Fix the last imports of `'invariant'`
f6b0c13 Expose Clipboard docs
c331d11 Fix breakages caused by switch to fbjs
e7499e3 limit number of workers
5a6a94b sync fbjni
5df3eeb Force 16 byte stack alignment on JNI method invocations on x86
d3f2081 Fix unit tests in open source environment
ab12189 Enable blurOnSubmit for text input in android
f827f7b instrumentation tests are executed with BUCK
4654b34 Revert Remove invariant hack for jest
170f452 Fix broken link
ad8a335 Remove knowledge of fbjs from the packager
ca67648 Revert ArrayBuffer support
e3de994 Merge pull request #6241 from bestander/manual-sync-prebuilt
00178b7 Added prebuilt folder with BUCK files to support BUCK run of ReactAndroid in OSS
25f7802 Fix UIExplorer Header
caac520 Add gesture handling for the card stack.
85801ef Remove invariant hack for jest
2957f73 removed bithound badge
6bae7f9 Add suggested ‘view size’ powers to -[RCTShadowView setFrame:]
b4dc5e3 Added TeamWarden App to website showcase
35da174 Added unit tests for module init
0db22f1 NavigationCardStack - Add card stack item.
cbc0e21 Support for XHR responseType and response attributes
c60ebf2 Update release schedule and steps
bd95b22 WebWorkers: Add ExecutorToken to route native module calls to/from workers
f67fa82 Add UIManager.measureInWindow to get window coordinates
d94a567 Add new worker for code transform, optimization, and dependency extraction
58f86b2 Don't execute things that may throw in Bridge/JSCExecutor dtors
a72c295 babel-preset-react-native: Make sure that `react-transform-hmr/lib/index.js` is included correctly for every module in the bundle
7e3266d Fix attributes checking for Image.android.js
9be1216 Minor code improvements for RCTTextInput
f130a36 Update known issues
73bdef4 Unify scene rederer params that are used render the scene / header.
e55cefc Add log message to bridge init
86d6d54 Add React.js 2016 Conf videos
d033380 Tweak wording of issue guidelines
10e8e38 Update GitHub issue guidelines
ffdd3e4 remove dead code
f331a58 Move initialization of RCTBatchedBridge into its own method.
d7d47d8 Defer constants gathering until after setup
8d44c2d Fix bridge tests
5a53d90 fix all anchor links in docs
fcd468d fix props anchor links
cf0c3d4 Update wc to latest version to remove insecure warning
79e9489 Add 'Linking' example
44fcf22 Fix crash when passing null to clearImmediate
3cc4f97 Remove 'displayName' prop from 'PickerExample' component
7c2c6a9 Show a Toast for HMR
8a042f4 Minor path change for message socket between packager and bridge (3/N)
3812c74 Guard navigator from dismatching gestures.
436db67 Allow parents to accept children modules
d7cee3a bump node-haste to 2.4.0
7383378 Fixed issue with opaque thumbnails being given an alpha channel
f99579a Try/catch exceptions in JSCExecutor for debugging crash
4b98511 Remove gating code for HMR on iOS
b2b41da Don't hardcode 'localhost:8081' as the _hmrURL in the Bundler
20588a6 Log HMR events
f420f81 Revert D2982150: Revert D2926896 WebWorkers: Move web worker impl to JSCExecutor
7032a64 Fix WebView example on iOS
f7df3bb Removed eager init of all ViewManagers on layout
c8835d0 Fix RCTLinkingManager crash on iOS7
9edfd94 Fix minor code nit from D2977441
9baef48 decouple textview from fresco
c32e5fd Revert D2926896 WebWorkers: Move web worker impl to JSCExecutor
50141f9 fix RCTPerfMonitor display unit error
251d5a5 Fixed flow error about require platform forked component
d032cc9 Pass jsc config to JSC
542432f Launch a new task if openURL is called with a url in a different package
b860897 Restore canvas once group has been drawn
732f2e1 List people who manage GitHub issues
c377f2a Add message channel to packager for sending commands to bridge (2/N)
7eb7b94 fix resources build variable name
ae0ad1f Implement modulo operator method
7d96dbb Added new app for showcase: Deskbookers
c449d9e Fix an issue (Sticky header index was outside the range) when renderSeparator is defined but returns null
a9846da support plain numbers in add and multiply operators
8b88cae Fix android's image tintColor prop when used with alpha
5112a63 Added ability to run Movies app with BUCK
9d3d9df Make fbsource and GitHub consistent
652c1c1 Fix incorrect MeasureSpec in ReactTextInputShadowNode
d9c0f24 Added the app Hover to the React Native showcase
29e6bac Fixed UIExplorerStateTitleMap.js being .ios only
480e9ab Sets up example for LegacyNavigator.
45a52c7 Support multiple interface orientations in RCTDevLoadingView
f51c16b Avoid dirtying layout when frame doesn't change
b8e7fe4 Copy exif data when resizing images in ImageEditingManager
13f2aea Fix for different geolocation timestamp for Android and iOS
f0689cf add Universal Links support to Linking.getInitialURL(). Fixes #6099
3ed66ee Fix scrollResponderScrollTo deprecated warning
2d921ee Resolve react flow definitions
6b80f11 Add switch for enabling nodes screenshot tests
6bcb2a0 Introducing NavigationCardStack
9836b29 Align stack on all JSC API calls
3640080 Remove unused variable
3faa70a Add guidelines for managing GitHub issues
4b4455f Removed 'screen' option from snapshot API
f538032 Sync CSSLayout: Make 'stretch' aligned children fill cross-axis in containers of undefined size in the cross-axis
936b5e7 Backed out changeset fe59b7f7c7da
3603479 Fix Platform.Version documentation
b8850df typo with in code, replace date.toTime with date.getTime
9a70ff0 Fix site generation
b4992ef Add disabled TouchableNativeFeedback button example
21ee7fd Fix mocks in NavigationExperimental
f7f3e7b Fix UIExample typos: hightlight -> highligh
5c41865 Remove duplicate register call
ec173b1 Add drawerLockMode prop to DrawerLayoutAndroid
9ae3714 Create offline package if not running in "Debug" config
11843fd Initialize glog in react native.
a759131 another patch hoping to fix chronos
96ecfad manual file sync for oss sync bot
25e1180 manual file sync for oss sync bot
4cd1947 manual file sync for oss sync bot
ecfd4f8 patch commit that was not synced from fbsource
9951e1a Introduce disabling for Touchable* elements
9d1abf0 Add the latest FIG colors to React Native color palette
7176c52 Dispatch JS calls to JS thread from c++ bridge
9e18b21 Minor improvements to Android docs
df5dd0b Docs: Animations.md, clarify how navigation animation is configured.
b41ad9f Upgrade node-haste to v2.3.0
ac12f98 Added support for taking snapshots of the screen, window or individual views
0513d3a revert D2928371 to unbreak drawer.
e0019f6 App linking for UIExplorer iOS
19f81be NavigationAnimatedView configurable navigation timing
dcb68db Add sub-reducer support to NavigationStackReducer
876ecb2 Adopt NavigationExperimental in UIExplorer
2551540 Add "Reading" case
c79fed4 Resolved UIExplorer StatusBarIOS deprecation warning
e3f19b1 Update EmbeddedAppAndroid.md
c17428e Schedule memory pressure handlers onto JS queue thread
5534f8b Fix instacrash on login in rnfeed
e6c6510 Add support for sharing images or other media via iOS share sheet
7964d80 Replace ModalFullscreenView constants by Dimensions
eb2cd07 Support rotation in RCTModalHostView
26a7335 Backed out changeset 837af947846b
b5d2667 Use nanoTime instead of currentTimeMillis for events
cf3bd9f Fix hidden StatusBar reappearing after exiting app on Android
b9ed72a Added a `root` option to the `run-android` command
ad17a2f Use ReactActivity for UIExplorer and Movies examples
93761c2 Add 'Collegiate - Learn Anywhere' to the showcase
91788d2 Deprecate PullToRefreshViewAndroid and remove it from the website
89ea985 Restrict the version range of node-haste to ~2.0.0
6f56538 Revert D2953499
8e809e9 fix broken drawer layout
2b46fd4 Clean up UIExplorer and seperate RCTRootView examples
9294c6f Initialize glog in react native.
54a423e fixed master branch
2b25163 WebWorkers: Allow web worker owner to inject globals into worker, supply modified __fbBatchedBridgeConfig
febb1fb WebWorkers: Move web worker impl to JSCExecutor
b454d31 Add position to Picker onValueChange's call
f961b78 Set WebView baseURL to 'about:blank' instead of nil
4b97137 Enable scalesPageToFit on Android
671b975 Fix a bug with ListView with sticky headers + RefreshControl
183d6a0 Adds category and alertAction properties to local notification details object
78a9125 Update `ScrollResponder.js` to use new `scrollTo` API
19a1c4c use a static react instance holder
b516976 Support custom ScrollView implementations in ListView
44ea74c Update jest to 0.9.0-fb2
ad15421 Merge pull request #6032 from bestander/sync-buck
0107d1a manual sync for D2949054
a6a4389 add the ability to create triangles using css tricks
a91466f Rename NavigationState module to NavigationStateUtils
26402ea Seperate NavigatorIOS Example from UIExplorer Navigation
fa3a67e Install node-haste2 and remove DependencyResolver
7a87d38 Fix typos in bot messages
0fdb167 Tweak bot messages and issue template to make them a bit more friendly
80e4581 Issue bot: add reopen command
e09b4a5 Tweak PR and issue templates
8956915 Move appcompat-orig alongside fork
f4e085a Clean up docs on building RN Android from source
3415e31 Adds additional help when a module is missing.
e0a0cac add getter as public api for ErrorUtils._globalHandler
62ac6ae showcase/whammy
fc52a65 Add MyMuesli to website showcase
8770fd9 add "烘焙帮" case
774757d Add Text destructuring to example
449d4d4 Remove old android support library version
9148620 fix an image cropping bug when displaySize is specified
82eeca6 Update + use node-haste2
403176a Also release Android sources to npm
1f6ad46 PR and Issue templates
5ec33d1 Tweak Hot Loading yellow box wording
8072822 Add video link and include new featured apps in showcase
b5f8006 Introduce transformer `cacheKey`
f2b95f2 Add commands for a new issue bot
7dc1d46 Fix the Portal display to not rerender the entire tree
b26f699 Add measureInWindow on Android
f9e81d9 Fix OSS iOS build
f73f417 Fixed relative links in generated docs
1e8991a Add android ndk dep
d0f1466 Default javaScriptEnabled to true
011dc89 Unbreak master build.
d8e07ea XMLHttpRequest.DONE is not defined. Fixes #5883
dab24b4 Enable persistent socket between packager and bridge (1/N).
1172e64 Add missing comma
0176ac4 Add hitSlop prop on iOS and Android
ecf6981 Only freeze valid attributes in `mountComponent`
d1dbe2d Add My IP to showcase
0427c3d Added throttling on requests made by RCTImageLoader
07a5f44 add removeReactInstanceEventListener and call it from onDestroy
f74981a Add `@providesModule NavigatorExample` to NavigatorExample.js
97c799a Update README.md
3e52df8 Using an updated version of Sinopia that works with node 4&5
41789e7 Simplify docs on generating Android release APK
e1fed60 Fix double-destruct of string on syntax error
027f26d Add back apps to showcase, making fbsource and GitHub consistent
8f19f5b Annotate WebSocket with Flow
edbe6a2 Add imperative API to StatusBar
9a918ef Improve performance of node-haste2 and react-packager
9856a97 Add sneat app
fa638c7 Remove React Devtools from debugging docs
c6a8fb9 Fix links to Flexbox / ShadowPropTypesIOS / Transforms in styles
4237a27 pick up some easy-to-fix lint warnings
d31b47c Add Text Blast to Example App Showcase
fae0335 trying to fix fbsource sync, reverting showcase.js to how it was on 2.12.2016 at fbsource
5c18158 Fixes NativeModules documentation typo
480f7cd fix es6 class method
14ec6f0 Use promises in 'NetInfo'
ecb1643 Yet another fix for CI to find branch that contaisn tag latest
e5ba46c Expose way for native modules to modify JSC context
46a8f1d Annotate Clipboard module
51a8b54 Cleaned up versions.html naming
9753bd9 Merge pull request #5862 from facebook/ide-patch-1
6c55d5b Replace custom rolled stable string hashing with library
b051d07 Update CONTRIBUTING.md
bestander commented 8 years ago

It should take 8 steps to pin point the broken commit

daesan commented 8 years ago

@bestander Thanks for printing this out! I will try to identify the offending commit.

bestander commented 8 years ago

Thanks for not giving up, @daesan. I am working on something that should allow you to use any commit in your app without rebuilding it manually. It won't help you with this task but will help in the future problems

daesan commented 8 years ago

@bestander Hey, thanks for bearing with me on this issue. ;)

Being able to alternate among different commits would definitely help a lot on issues like this!

From the commits list you gave me, I tried to sample them and build my app with them.

For some reason, first commit record (b051d07 Update CONTRIBUTING.md) already broke the build. I got the error "Command /bin/sh failed with exit code 1" on XCode. (This puzzles me a little. Shouldn't this build without problem since it's almost identical to 0.21.0-stable?)

First commit that did build successfully, that I found, was "eb53194 Fix the last imports of 'invariant'". However, this already had "EXC_BAD_ACCESS" error on NSHTTPCookieStorage.

I tried to sample several commits between "b051d07" (first commit) and "eb53194" (the one that builds), but none of them builds successfully. The following is the list:

f6b0c13, 00178b7, 2957f73, cf0c3d4, c8835d0, a759131, 54a423e, 9148620, f9e81d9, 97c799a

I am not sure how to process from here on. Do you have any suggestions?

Thanks!

daesan commented 8 years ago

@bestander Hey, this doesn't quite make sense.

Commit eb53194 is merely a changes to JS files. Why would this commit fix the build? Does the commits list you shared above strictly in order?

daesan commented 8 years ago

@bestander Okay. I spent all day and found out that the offending commits are the followings: dab24b4, f9e81d9. The commit title is "Enable persistent socket between packager and bridge" but it doesn't have any detailed explanation.

How should I proceed from here on? Should I try to communicate with the author of the commit?

bestander commented 8 years ago

Thanks so much @daesan! I'll chase the guys to know the details and we will work on a patch asap!

frantic commented 8 years ago

@daesan awesome job, thank you! As a temporary workaround, can you try setting your bundleURL to <your-ip>:80 (i.e. explicitly setting the port to 80)?

daesan commented 8 years ago

@frantic Ah, that's what "(null)" part meant in the debugging console. Can't believe I missed that!

Thanks for sharing that workaround! :)

By the way, could you explain briefly what that commit does? Is it related to Hot Reloading?

daesan commented 8 years ago

@frantic I applied the workaround you suggested. However, when I run my app, I get the following error with red screen on iPhone:

WebSocket connection failed with error ERRORDOMAIN=RCTSRWebSocketErrorDomain Code=2132 "received bad response code from server 404" UserInfo={NSLocalizedDescription=received bad response code from server 404, HTTPResponseStatusCode=404}

If I "reload JS", this error goes aways and reloading works without any problem, until I restart the app. On the console of the server(npm start), I get the following error:

::ffff:127.0.0.1 - - [25/Mar/2016:03:00:35 +0000] "GET /message?role=shell HTTP/1.0" 404 31 "-" "-"

Also, if I "Enable Live Reload", I get the following error with red screen on iPhone:

locals[0] does not appear to be a 'module' object with Hot Module replacement API enabled. You should disable react-transform-hmr in production by using 'env' section in Babel configuration. See the example in README ...

bottledwalter commented 8 years ago

@daesan, for the first error message ("Websocket connection..."), what port is your packager running on? The packager defaults to (8081), so unless you're using a custom port, can you try that port instead of 80 to workaround the bug?

daesan commented 8 years ago

@bottledwalter Got you. I tried 8081 and it works without any errors.

Please let me know if I can be of help for debugging.

daesan commented 8 years ago

@frantic @bottledwalter Regarding the second error message ("locals[0] does not..."), it turns out that this happens only when I disable dev mode in bundle URL. If I set dev=true, this error goes away. It would be better if Hot Reloading works with dev=false, though.

frantic commented 8 years ago

@bottledwalter has landed a fix. Please reopen if this still doesn't work.

Regarding hot reloading, I'm pretty sure it will not work with dev=false because it relies on some dev-only transforms and doesn't make much sense for prod builds.

daesan commented 8 years ago

@frantic Thanks for letting me know.

Running from "0.23-stable", I can now use port 80 for JSX bundle loading. However, "Hot Reloading" still does not work. I applied @bottledwalter's patch above (3226b59). It does not seem to help.

Could you reopen the issue? I don't seem to have that privilege.

lacker commented 8 years ago

This issue has been stale for a while with a bunch of folks submitting things to fix it, so I'm going to guess it's fixed and closed it. If this is still a problem then feel free to reopen.