search

facebook / react-strict-dom

React Strict DOM (RSD) is a subset of React DOM, imperative DOM, and CSS that supports web and native targets
MIT License
2.97k stars 149 forks source link

Adding regex handling for negative signs #108

Closed mellyeliu closed 1 month ago

mellyeliu commented 1 month ago

Context

Add parsing for signage in string length unit values:

Testing

Modifying tests to account for positive and negative signs

Ran npm run jest /packages/react-strict-dom/tests/css-test.native.js

github-actions[bot] commented 1 month ago

compressed-size: runtime library

Size change: +0.00 kB Total size: 18.57 kB

Filename: gzip (minify) kB size kB change % change
./packages/react-strict-dom/dist/native/index.js 14.63 (46.08) +0.00 (+0.00) 0.0% (0.0%)
View unchanged | Filename: gzip (minify) | kB size | kB change | % change | | :--- | :--- | :--- | :--- | | `./packages/react-strict-dom/dist/dom/index.js` | **2.99** (9.00) | **0.00** (0.00) | **0.0%** (0.0%) | | `./packages/react-strict-dom/dist/dom/runtime.js` | **0.95** (2.33) | **0.00** (0.00) | **0.0%** (0.0%) |
necolas commented 1 month ago

Thanks for working on the fix! Please leave merging to maintainers next time