search

facebook / react-strict-dom

React Strict DOM (RSD) standardizes the development of styled React components for web and native.
https://facebook.github.io/react-strict-dom
MIT License
3.19k stars 161 forks source link

feat: mark `inset*`, `marginBlock*`, `marginInline*`, `paddingBlock*` and `paddingInline*` props as built-in support #219

Open ecreeth opened 1 month ago

ecreeth commented 1 month ago

This layout props have been implemented in main (default as of 0.76).

Check 46478 for more information.

Should we continue to test these props?

ecreeth commented 1 month ago

I'm getting this coverage error: 

Jest: "global" coverage threshold for branches (89%) not met: 88.79%

Weird... I didn't add any new functionality.

necolas commented 1 month ago

We haven't been using the built in support because all logical styles aren't fully implemented in RN yet, and we had problems in the past with missing desktop support. I'll ask around and see if we can start to drop some of the polyfills

ecreeth commented 1 month ago

Looks like a miss the direction prop. Now is supported on both platforms.

See https://github.com/facebook/react-native/blob/main/packages/react-native/Libraries/StyleSheet/StyleSheetTypes.d.ts#L114