search

facebook / react

The library for web and native user interfaces.
https://react.dev
MIT License
228.54k stars 46.78k forks source link

Subject: Optimization Proposal Code Initialization Enhancement for Improved Performance #27861

Closed sanjaiyan-dev closed 6 months ago

sanjaiyan-dev commented 9 months ago

Subject: Code Clarification, Optimization Proposal, and Apology

I've noticed a section of the code that could be optimized for performance. In the following lines:

https://github.com/facebook/react/blob/c5b9375767e2c4102d7e5559d383523736f1c902/packages/react-reconciler/src/ReactFiberRoot.js#L113-L119

There's an opportunity to optimize the initialization of pendingUpdatersLaneMap using the native .fill method. This change has the potential to improve performance by 70 to 80%. I apologize for any inconvenience caused by this suggestion, and I understand that changes to critical sections of code should be approached with caution.

I'm happy to provide more details, clarification, or work closely with you to address any concerns. Please let me know if further explanation or code samples are needed.

Thank you for your understanding.

github-actions[bot] commented 6 months ago

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

github-actions[bot] commented 6 months ago

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!