search

facebook / react

The library for web and native user interfaces.
https://react.dev
MIT License
229k stars 46.86k forks source link

Error when `__source` is provided to production build #9832

Open sebmarkbage opened 7 years ago

sebmarkbage commented 7 years ago

Currently if the __source transform is enabled together with the production build there are no indicators of a poorly performant configuration. https://facebook.github.io/react/ even has it.

We already check for the existence of a __source field. So we can just reuse the same check to issue something in prod mode if it exists.

The problem is that we don't have any warning module in prod and it is unclear if it would get attention or even considered to spammy in prod.

We could throw but that might be too extreme since a misconfiguration would kill the site.

We could also use this to set a flag on the __REACT_DEVTOOLS_GLOBAL_HOOK__ object. The icon in the devtools extension could use this to indicate a misconfigured build.

gaearon commented 7 years ago

We could also use this to set a flag on the __REACT_DEVTOOLS_GLOBAL_HOOK__ object. The icon in the devtools extension could use this to indicate a misconfigured build.

This sounds reasonable to me.