search

facebook / redex

A bytecode optimizer for Android apps
https://fbredex.com/
MIT License
6.02k stars 653 forks source link

Convert circleci workflows to github actions #852

Closed robandpdx closed 4 months ago

robandpdx commented 5 months ago

This pull request converts the CircleCI workflows to GitHub actions workflows.

build-deb_oldoldstable job fails with the following error.

/bin/bash: dx: command not found

Here is the latest workflow run in my fork.

https://fburl.com/workplace/f6mz6tmw

thezhangwei commented 5 months ago

Thanks for putting up the change. It looks like the remaining issue is that the dx binary cannot be found for one of the build?

facebook-github-bot commented 5 months ago

@thezhangwei has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

thezhangwei commented 5 months ago

Hey @robandpdx how can we kick off the github action run on a PR if we were to iterate on top of this change?

robandpdx commented 5 months ago

Hey @robandpdx how can we kick off the github action run on a PR if we were to iterate on top of this change?

@thezhangwei I have been working in a fork and merging changes to main in my fork in order to trigger the workflows.

bigfootjon commented 4 months ago

https://github.com/facebook/redex/commit/3e74d9319b0c2479c867b86a0b046e7294fd8ac6 did this instead