search

facebook / relay

Relay is a JavaScript framework for building data-driven React applications.
https://relay.dev
MIT License
18.42k stars 1.83k forks source link

Not existing connection in config must warn the developer #2341

Open steida opened 6 years ago

steida commented 6 years ago

Silent fails ar bad. This is the workaround I use but with mutation config, we are doomed. Please consider dev warning. Thank you.

screen shot 2018-02-23 at 00 28 11

sibelius commented 6 years ago

The connection could be garbage collected, so there is no reason to add the edge to it

steida commented 6 years ago

Except with this config:

const configs = [
  {
    type: 'NODE_DELETE',
    deletedIDFieldName: 'id',
  },
];

I just got:

screen shot 2018-02-23 at 00 54 56

Because a node is null.

sibelius commented 6 years ago

deletedIDFieldName could be a variable, so I think this is not possible

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.