Open hannanstd opened 3 months ago
Hi @hannanstd!
Thank you for your pull request and welcome to our community.
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
At this point we are not investing in improving the older higher-order-components APIs and are instead focused on the hooks-based APIs.
Do the hooks apis (useLazyLoadQuery
, etc) allow you to get the behavior you want?
@captbaritone
Hello, Thank you for your answer. but it is not investing in improving. this problem/bug exists in the relay and many legacy projects use it.
This change would not cause any issues or break changes. it just adds the environment configName
to the cachekey
and can be reviewed quickly but it helps others.
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Sometimes we have to have two or more
ReactRelayQueryRenderer
with different environments at the same time. So the problem is thatrequestCache
is used as a shared variable to hold both environments's caches. On the other hand, as you know each environment can have itsconfigName
while we creating it. It makes sense that therequestCacheKey
consists of thisconfigName
to isolate each environment from the others. This PR does that. see the added Unit Tests.Also, it can solve some issues that were reported before regarding the SSR.