search

facebook / relay

Relay is a JavaScript framework for building data-driven React applications.
https://relay.dev
MIT License
18.27k stars 1.8k forks source link

Activate LSP for schema and schema extension files #4652

Closed tobias-tengler closed 2 months ago

tobias-tengler commented 3 months ago

This is in preparation for adding LSP support for schema and schema extension files.

captbaritone commented 3 months ago

Awesome! I'm curious how/if you were able to verify these changes. This LSP stuff can be hard to test (especially when they require changes to the VSCode extension as well)

tobias-tengler commented 3 months ago

Yes, I was able to verify it. I started the extension development host and opened my lsp playground repository, which is configured to point to the locally built relay binary. I then observed the extension displaying the Relay: ready message, when I opened the configured schema or a schema extension file.

tobias-tengler commented 3 months ago

@captbaritone Addressed :)

facebook-github-bot commented 3 months ago

@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 months ago

@captbaritone merged this pull request in facebook/relay@964e078395a8b5ef2d86eea33d524cda375e3572.