Normalize paths in diagnostics CLI output

facebook / relay

Relay is a JavaScript framework for building data-driven React applications.

https://relay.dev

MIT License

18.24k stars 1.8k forks source link

Normalize paths in diagnostics CLI output #4709

Closed captbaritone closed 1 week ago

captbaritone commented 1 week ago

This should fix the current breakage of our windows tests. One thing I'm not sure about is if this will cause any problems with things like clickable file paths in the terminal on Windows.

facebook-github-bot commented 1 week ago

@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

captbaritone commented 1 week ago

cc @alloy in case you know if replacing slashes in paths written to the CLI will break things for Windows users.

facebook-github-bot commented 1 week ago

@captbaritone merged this pull request in facebook/relay@7b651016d5cb4cdf1f51d377c23133f3ae4552b4.