search

facebook / relay

Relay is a JavaScript framework for building data-driven React applications.
https://relay.dev
MIT License
18.41k stars 1.83k forks source link

Make workspace root lazy static to try to avoid cwd race condition #4784

Closed captbaritone closed 1 month ago

captbaritone commented 2 months ago

Trying to get more info on the failure I see here: https://github.com/facebook/relay/actions/runs/10742885102/job/29796930703

captbaritone commented 2 months ago

I think it’s a flaky situation due to integration tests running in that process changing the CWD in async tasks in a way that is unpredictable

facebook-github-bot commented 2 months ago

@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

captbaritone commented 1 month ago

This landed as https://github.com/facebook/relay/commit/e1f2177c0cddff932fd04c90ccca068768b07dd8