search

facebook / relay

Relay is a JavaScript framework for building data-driven React applications.
https://relay.dev
MIT License
18.38k stars 1.82k forks source link

Adds back the missing resolver type import in Typescript files #4791

Closed Markionium closed 6 days ago

Markionium commented 2 weeks ago

When trying to improve Typescript types we made the wrong assumption that the resolver type import was always unused in Typescript files. We missed the fact that it is used in the scenario where RelayResolverType is provided as the return value of a resolver. (See issue #4790)

The TODO's remain as there is still work to do to add Context support to the resolvers.

captbaritone commented 1 week ago

Thanks!

facebook-github-bot commented 1 week ago

@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 week ago

@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

captbaritone commented 1 week ago

Hey. I'm hitting an internal infra issue importing this PR. I think there's some cases where if a PR needs to get rebased on import it can time out. Sorry to ask this, but do you mind reopening this as a new PR?

Markionium commented 1 week ago

@captbaritone do we still need this though? Didn't you do almost exactly the same here?

https://github.com/facebook/relay/commit/4782743b8b0f2bc7a0cc133b92628e92e0ef57ac

captbaritone commented 1 week ago

Ah, right. I last track of that. Should we just close this PR?

Markionium commented 6 days ago

Yep, closed!