search

facebook / relay

Relay is a JavaScript framework for building data-driven React applications.
https://relay.dev
MIT License
18.41k stars 1.83k forks source link

Replace story.image for story.thumbnail #4793

Closed theodorekouzelis closed 1 month ago

theodorekouzelis commented 2 months ago

The Story component expects the property to be named "thumbnail" https://github.com/relayjs/relay-examples/blob/main/newsfeed/src/components/Story.tsx#L24

facebook-github-bot commented 2 months ago

Hi @theodorekouzelis!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 2 months ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

captbaritone commented 1 month ago

Thanks!

facebook-github-bot commented 1 month ago

@captbaritone has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 month ago

@captbaritone merged this pull request in facebook/relay@e414904ba8519b476a5f8ce0524f7d1dec646cc2.