Disable `inplace_update_support` in crash test with unsynced data loss

facebook / rocksdb

A library that provides an embeddable, persistent key-value store for fast storage.

http://rocksdb.org

GNU General Public License v2.0

28.09k stars 6.25k forks source link

Disable `inplace_update_support` in crash test with unsynced data loss #12673

Closed cbi42 closed 3 months ago

cbi42 commented 3 months ago

Summary: With unsynced data loss, we replay traces to recover expected state to DB's latest sequence number. With inplace_update_support, the largest sequence number of memtable may not reflect the latest update. This is because inplace updates in memtable do not update sequence number. So we disable inplace_update_support where traces need to be replayed.

facebook-github-bot commented 3 months ago

@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 months ago

@cbi42 merged this pull request in facebook/rocksdb@c4782bde41fa368de3b9c63570357c8063f6e88e.