Closed HypenZou closed 1 month ago
@hx235 thx for review🙏🏻
unit test and history entry has been added
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@HypenZou has updated the pull request. You must reimport the pull request before landing.
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@HypenZou has updated the pull request. You must reimport the pull request before landing.
@HypenZou has updated the pull request. You must reimport the pull request before landing.
@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@ajkr merged this pull request in facebook/rocksdb@5bb7f95ed6688b914841749e0d192986ce4c252f.
Context/Summary: It seems unreasonable to take the archived log size into account when calculating log size for flush in method CreateCheckpoint. If the user sets WAL_ttl_seconds or WAL_size_limit_MB, the argument _log_size_forflush can easily be reached due to the size of the archived dir. As a result, the flush may always be triggered. Test corverd by ./checkpoint_test