search

facebook / rocksdb

A library that provides an embeddable, persistent key-value store for fast storage.
http://rocksdb.org
GNU General Public License v2.0
28.09k stars 6.25k forks source link

Fix rebuilding transactions containing PutEntity #12681

Closed ltamasi closed 2 months ago

ltamasi commented 2 months ago

Summary: When rebuilding transactions during recovery, MemtableInserter::PutCFImpl currently calls WriteBatchInternal::Put regardless of value type, which is incorrect for PutEntity entries, as well as TimedPuts and the blob indexes used by the old BlobDB implementation. The patch fixes the handling of PutEntity and returns NotSupported for TimedPuts and blob indices.

Differential Revision: D57636355

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D57636355

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D57636355

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D57636355

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D57636355

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D57636355

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D57636355

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D57636355

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D57636355

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D57636355

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D57636355

ltamasi commented 2 months ago

Thanks for the reviews @jowlyzhang and @jaykorean !

facebook-github-bot commented 2 months ago

This pull request has been merged in facebook/rocksdb@62600cb2d4bf6392d871103cad5a31102c669bea.