Closed ltamasi closed 2 months ago
This pull request was exported from Phabricator. Differential Revision: D57636355
This pull request was exported from Phabricator. Differential Revision: D57636355
This pull request was exported from Phabricator. Differential Revision: D57636355
This pull request was exported from Phabricator. Differential Revision: D57636355
This pull request was exported from Phabricator. Differential Revision: D57636355
This pull request was exported from Phabricator. Differential Revision: D57636355
This pull request was exported from Phabricator. Differential Revision: D57636355
This pull request was exported from Phabricator. Differential Revision: D57636355
This pull request was exported from Phabricator. Differential Revision: D57636355
This pull request was exported from Phabricator. Differential Revision: D57636355
Thanks for the reviews @jowlyzhang and @jaykorean !
This pull request has been merged in facebook/rocksdb@62600cb2d4bf6392d871103cad5a31102c669bea.
Summary: When rebuilding transactions during recovery,
MemtableInserter::PutCFImpl
currently callsWriteBatchInternal::Put
regardless of value type, which is incorrect forPutEntity
entries, as well asTimedPut
s and the blob indexes used by the old BlobDB implementation. The patch fixes the handling ofPutEntity
and returnsNotSupported
forTimedPut
s and blob indices.Differential Revision: D57636355