Fix txn_write_policy check in crash test script

facebook / rocksdb

A library that provides an embeddable, persistent key-value store for fast storage.

http://rocksdb.org

GNU General Public License v2.0

28.09k stars 6.25k forks source link

Fix txn_write_policy check in crash test script #12683

Closed ltamasi closed 2 months ago

ltamasi commented 2 months ago

Summary: With optimistic transactions, the stress test parameter txn_write_policy is not applicable and is thus not set. When the parameter is subsequently checked, Python's dictionary get method returns None, which is not equal to zero. The net result of this is that currently, sync_fault_injection and manual_wal_flush_one_in are always disabled in optimistic transaction mode (most likely unintentionally).

Differential Revision: D57655339

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D57655339

facebook-github-bot commented 2 months ago

This pull request was exported from Phabricator. Differential Revision: D57655339

facebook-github-bot commented 2 months ago

This pull request has been merged in facebook/rocksdb@ad6f6e24c80c8aa14ab107711ecf2de482ad89cf.