search

facebook / rocksdb

A library that provides an embeddable, persistent key-value store for fast storage.
http://rocksdb.org
GNU General Public License v2.0
28.09k stars 6.25k forks source link

Flush WAL upon DB close #12684

Closed hx235 closed 2 months ago

hx235 commented 2 months ago

Context/Summary: https://github.com/facebook/rocksdb/pull/12556 avoid_sync_during_shutdown=false missed an edge case where manual_wal_flush == true so WAL sync will still miss unflushed WAL. This PR fixes it.

Test plan: modified UT to include this case manual_wal_flush==true

facebook-github-bot commented 2 months ago

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 months ago

@hx235 has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 2 months ago

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 months ago

@hx235 has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 2 months ago

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 months ago

@hx235 merged this pull request in facebook/rocksdb@733150f6aaf52c8dcedb843fc329b472bba4ffd7.