Closed hx235 closed 2 months ago
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@hx235 has updated the pull request. You must reimport the pull request before landing.
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@hx235 has updated the pull request. You must reimport the pull request before landing.
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@hx235 merged this pull request in facebook/rocksdb@733150f6aaf52c8dcedb843fc329b472bba4ffd7.
Context/Summary: https://github.com/facebook/rocksdb/pull/12556
avoid_sync_during_shutdown=false
missed an edge case wheremanual_wal_flush == true
so WAL sync will still miss unflushed WAL. This PR fixes it.Test plan: modified UT to include this case
manual_wal_flush==true