Fix c++ compilation errors on Linux using g++

[mmucklo]

This PR fixes a number of compilation errors seen compiling on Linux (Ubuntu 22.04.4 LTS) using cmake 3.29 and g++ 11.4.0

Sampling of errors fixed are as follows:

rocksdb/table/block_based/block.cc:1330:31: error: cast from type ‘const rocksdb::Block*’ to type ‘void*’ casts away qualifiers [-Werror=cast-qual]
rocksdb/test_util/testutil.h:272:14: error: cast from type ‘const char*’ to type ‘char*’ casts away qualifiers [-Werror=cast-qual]
rocksdb/util/stderr_logger.cc:36:53: error: format not a string literal, argument types not checked [-Werror=format-nonlteral]
rocksdb/util/string_util.cc:165:29: error: ‘%c’ yields only last 2 digits of year in some locales [-Werror=format-y2k]

NOTES: cache/compressed_secondary_cache.cc - UncompressedData already takes in a const char, so no need to cast to (char )

const_cast is used to remove const qualifiers. static_cast is used to change types (largely from one pointer type to another). reinterpret_castwas used in places that static_cast would not work.

[facebook-github-bot]

Hi @mmucklo!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!