search

facebook / rocksdb

A library that provides an embeddable, persistent key-value store for fast storage.
http://rocksdb.org
GNU General Public License v2.0
27.9k stars 6.21k forks source link

Support PutEntity as write method in the transactional MultiGet stress test #12699

Closed ltamasi closed 1 month ago

ltamasi commented 1 month ago

Summary: The patch adds PutEntity to the potential write operations used in the read-your-own-writes tests for Transaction::MultiGet. Note that since the stress test generates wide-column structures which have the value returned by GenerateValue in the default column, this does not affect the results returned by the MultiGet API (unless we have a bug).

The wide-column entity is generated according to the usual rules based on the value base and the use_put_entity_one_in flag. The entire entity structure will be validated by the upcoming stress test for Transaction::MultiGetEntity, where we also plan to leverage this logic.

Differential Revision: D57799075

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D57799075

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D57799075

hx235 commented 1 month ago

It will be great to attach a testing command even if it's simple :)

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D57799075

ltamasi commented 1 month ago

Thanks for the thorough review!

facebook-github-bot commented 1 month ago

This pull request has been merged in facebook/rocksdb@5cec4bbcab07e7ab925513a0dd133f104f91e1a6.