search

facebook / rocksdb

A library that provides an embeddable, persistent key-value store for fast storage.
http://rocksdb.org
GNU General Public License v2.0
27.9k stars 6.21k forks source link

Fix `max_read_amp` value in crash test #12701

Closed cbi42 closed 1 month ago

cbi42 commented 1 month ago

It should be no less than level0_file_num_compaction_trigger(which defaults to 4) when set to a positive value. Otherwise DB open will fail.

Test plan: crash test not failing DB open due to this option value.

facebook-github-bot commented 1 month ago

@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 month ago

@cbi42 merged this pull request in facebook/rocksdb@0ee7f8bacb727886ac30e866299d5badc72dcf27.