search

facebook / rocksdb

A library that provides an embeddable, persistent key-value store for fast storage.
http://rocksdb.org
GNU General Public License v2.0
27.9k stars 6.21k forks source link

Remove unneccessary MutexLock from NonBatchedOpStressTest::TestGetEntity #12709

Closed ltamasi closed 1 month ago

ltamasi commented 1 month ago

Summary: This is most likely copypasta from TestGet from before https://github.com/facebook/rocksdb/pull/11058 . There is no need to lock the mutex for the key for reads; in fact, doing so is detrimental to test coverage since it locks out concurrent writers.

Differential Revision: D57915207

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D57915207

facebook-github-bot commented 1 month ago

This pull request was exported from Phabricator. Differential Revision: D57915207

facebook-github-bot commented 1 month ago

This pull request has been merged in facebook/rocksdb@d9316260e4726832d11e6c33e35067982970555a.