Fail DeleteRange() early when row_cache is configured

facebook / rocksdb

A library that provides an embeddable, persistent key-value store for fast storage.

http://rocksdb.org

GNU General Public License v2.0

27.9k stars 6.21k forks source link

Fail DeleteRange() early when row_cache is configured #12710

Closed cbi42 closed 1 month ago

cbi42 commented 1 month ago

Summary: #12512 added the sanity check for this incompatible combination. However, it does the check during memtable insertion which can turn the DB into read-only mode. This PR moves the check earlier so that this write failure will not turn the DB into read-only mode and affect other DB operations.

Test plan:

updated unit test DBRangeDelTest.RowCache to write to DB after a failed DeleteRange(). The test fails before this PR.

facebook-github-bot commented 1 month ago

@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 month ago

@cbi42 merged this pull request in facebook/rocksdb@af3be5255ac846be858c1a1ae9b4a196b8a9a103.