search

facebook / rocksdb

A library that provides an embeddable, persistent key-value store for fast storage.
http://rocksdb.org
GNU General Public License v2.0
27.85k stars 6.2k forks source link

Revert PR 12684 and 12556 #12738

Closed hx235 closed 1 month ago

hx235 commented 1 month ago

Context/Summary: a better API design is decided lately so we decided to revert these two changes.

Test plan:

facebook-github-bot commented 1 month ago

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 month ago

@hx235 has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 1 month ago

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

hx235 commented 1 month ago

Rebasing

facebook-github-bot commented 1 month ago

@hx235 has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 1 month ago

@hx235 has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 1 month ago

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 month ago

@hx235 has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 1 month ago

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 month ago

@hx235 has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 1 month ago

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 month ago

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 month ago

@hx235 merged this pull request in facebook/rocksdb@390fc55ba15912751591a4522e701a760b80640a.