search

facebook / rocksdb

A library that provides an embeddable, persistent key-value store for fast storage.
http://rocksdb.org
GNU General Public License v2.0
28.38k stars 6.29k forks source link

Enable reopen with un-synced data loss in crash test #12746

Closed hx235 closed 3 months ago

hx235 commented 3 months ago

Context/Summary: https://github.com/facebook/rocksdb/pull/12567 disabled reopen with un-synced data loss in crash test since we discovered un-synced WAL loss and we currently don't support prefix recovery in reopen. This PR explicitly sync WAL data before close to avoid such data loss case from happening and add back the testing coverage.

Test: CI

facebook-github-bot commented 3 months ago

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 months ago

@hx235 has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 3 months ago

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 months ago

@hx235 has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 3 months ago

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 months ago

@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 months ago

@hx235 merged this pull request in facebook/rocksdb@d3c4b7fe0bd0b7f3ec27895c517d43cc6b4c06ad.