Closed hx235 closed 2 weeks ago
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@hx235 has updated the pull request. You must reimport the pull request before landing.
@hx235 has updated the pull request. You must reimport the pull request before landing.
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
Need to fix more places apparently https://github.com/facebook/rocksdb/actions/runs/9474358341/job/26103793559?pr=12752
Need to fix more places apparently https://github.com/facebook/rocksdb/actions/runs/9474358341/job/26103793559?pr=12752
I am just passing by but it appears to be PositionedAppend() considering it is direct I/O, and PositionedAppend() does not update the state_
.
Looks good once that is resolved!
@hx235 has updated the pull request. You must reimport the pull request before landing.
Looks good once that is resolved!
Fixed - turns out that we also truncate under direct IO so need to update the pos (now renamed to post_at_last_append) for better naming.
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@hx235 has updated the pull request. You must reimport the pull request before landing.
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@hx235 merged this pull request in facebook/rocksdb@d0259c2c9826c48a45cb45558a245f304507c9a8.
Context/Summary: There are a few blockers to enabling reading un-synced data in db stress test (1) GetFileSize() will always return 0 for file written under direct IO because we don't track the last flushed position for
TestFSWritableFile
under direct IO. So it will surface as(2) A couple minor FIXME in left in https://github.com/facebook/rocksdb/pull/12729.
This PR fixed (1) and (2) and enabled reading un-synced data in stress test.
Test: