search

facebook / rocksdb

A library that provides an embeddable, persistent key-value store for fast storage.
http://rocksdb.org
GNU General Public License v2.0
27.85k stars 6.2k forks source link

`GetAggregatedIntProperty` accumulates property once per block cache #12755

Closed jonahgao closed 2 weeks ago

jonahgao commented 3 weeks ago

Fix issue https://github.com/facebook/rocksdb/issues/12687.

A block cache may be shared by multiple column families. Therefore, when getting the aggregated property of the block cache, we need to deduplicate by instances of the block cache, meaning the same instance should only be counted once.

facebook-github-bot commented 3 weeks ago

@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 weeks ago

@jonahgao has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 2 weeks ago

@jonahgao has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 2 weeks ago

@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 weeks ago

@ajkr merged this pull request in facebook/rocksdb@9f95aa82699b63073db1f843fe04c311035c0bd2.

jonahgao commented 2 weeks ago

Thank you @ajkr for reviewing and improving the code.