facebook / rocksdb

A library that provides an embeddable, persistent key-value store for fast storage.
http://rocksdb.org
GNU General Public License v2.0
27.85k stars 6.2k forks source link

Propagate more ReadOptions to ApproximateOffsetOf/Sizes #12764

Closed pdillinger closed 3 weeks ago

pdillinger commented 3 weeks ago

Summary: Unknown why these would ignore options like deadline and read_tier. Setting total_order_seek=true is unnecessary because of the disable_prefix_seek (= true) parameter to NewIndexIterator. This is only used by the hash index, which uses total order seek if either the ReadOption or the parameter is true. The parameter is arguably redundant with the total_order_seek option, meaning it could be eliminated, but I think this case is exceptional (compared to e.g. no_io):

Also added a generic release note to cover this and related PRs.

Test Plan: existing tests

facebook-github-bot commented 3 weeks ago

@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 weeks ago

@pdillinger merged this pull request in facebook/rocksdb@3abcba8470d090dacf8f9a55bb6feec0ec640355.