Closed pdillinger closed 2 weeks ago
@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@pdillinger has updated the pull request. You must reimport the pull request before landing.
@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@pdillinger merged this pull request in facebook/rocksdb@71f9e6b5b36e3223e8dba29df75e4e5008818d16.
Summary: Implemented two key segment extractors that satisfy the "segment prefix property," one with variable segment widths and one with fixed. Used these to create a couple of named configs and versions that are randomly selected by the crash test. On the read side, the required table_filter is set up everywhere I found the stress test uses iterator_upper_bound.
Writing filters on new SST files and applying filters on SST files to range queries are configured independently, to potentially help with isolating different sides of the functionality.
Not yet implemented / possible follow-up:
Test Plan: Some stress test trial runs, including with ASAN. Inserted some temporary probes to ensure code was being exercised (more or less) as intended.