Verify public headers do not reference internal ones

facebook / rocksdb

A library that provides an embeddable, persistent key-value store for fast storage.

http://rocksdb.org

GNU General Public License v2.0

27.85k stars 6.2k forks source link

Verify public headers do not reference internal ones #12774

Closed pdillinger closed 3 weeks ago

pdillinger commented 3 weeks ago

Summary: This is not currently caught by our public CI so adding a form of this check to make check-headers, which is part of the build-linux-unity-and-headers GHA job.

Test Plan: manually added a violation, which was caught. Also caught an existing trivial violation (fixed). CI will verify it plays nice with GHA.

facebook-github-bot commented 3 weeks ago

@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 weeks ago

@pdillinger merged this pull request in facebook/rocksdb@d6979bda409504c98261426b27220d3f48eabbac.