Closed jaykorean closed 2 weeks ago
@jaykorean has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@jaykorean has updated the pull request. You must reimport the pull request before landing.
@jaykorean has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@jaykorean has updated the pull request. You must reimport the pull request before landing.
@jaykorean has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@cbi42 That's a good question. Maybe we felt comparing keys are enough for the iterator verification when we first wrote this?
But anyway, I think it's worth adding the extra verification by comparing the value().
@jaykorean merged this pull request in facebook/rocksdb@b8c9a2576af6a1d0ffcfbb517dfcb7e7037bd460.
Summary
As title. Changes include the following
Refresh()
moved fromIterator
interface toIteratorBase
so thatAttributeGroupIterator
can also have Refresh() API (implemention will be added in the future PR)TestIterate()
's main logic refactored intoTestIterateImpl()
so that it can be shared withTestIterateAttributeGroups()
VerifyIterator()
also changed so that verification code can be shared betweenIterator
andAttributeGroupIterator
Test Plan
Single CF Iterator
CoalescingIterator
AttributeGroupIterator