facebook / rocksdb

A library that provides an embeddable, persistent key-value store for fast storage.
http://rocksdb.org
GNU General Public License v2.0
27.85k stars 6.2k forks source link

Add AttributeGroupIterator to Stress Test #12776

Closed jaykorean closed 2 weeks ago

jaykorean commented 3 weeks ago

Summary

As title. Changes include the following

Test Plan

Single CF Iterator

python3 tools/db_crashtest.py blackbox --simple --max_key=25000000 --write_buffer_size=4194304 --use_attribute_group=0 --use_put_entity_one_in=1 --use_multi_get=1 --use_multi_cf_iterator=0 --verify_iterator_with_expected_state_one_in=2

CoalescingIterator

python3 tools/db_crashtest.py blackbox --simple --max_key=25000000 --write_buffer_size=4194304 --use_attribute_group=0 --use_put_entity_one_in=1 --use_multi_get=1 --use_multi_cf_iterator=1 --verify_iterator_with_expected_state_one_in=2

AttributeGroupIterator

python3 tools/db_crashtest.py blackbox --simple --max_key=25000000 --write_buffer_size=4194304 --use_attribute_group=1 --use_put_entity_one_in=1 --use_multi_get=1 --use_multi_cf_iterator=1 --verify_iterator_with_expected_state_one_in=2
facebook-github-bot commented 3 weeks ago

@jaykorean has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 weeks ago

@jaykorean has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 3 weeks ago

@jaykorean has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 weeks ago

@jaykorean has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 2 weeks ago

@jaykorean has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

jaykorean commented 2 weeks ago

@cbi42 That's a good question. Maybe we felt comparing keys are enough for the iterator verification when we first wrote this?

But anyway, I think it's worth adding the extra verification by comparing the value().

facebook-github-bot commented 2 weeks ago

@jaykorean merged this pull request in facebook/rocksdb@b8c9a2576af6a1d0ffcfbb517dfcb7e7037bd460.