Closed hx235 closed 1 week ago
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@hx235 has updated the pull request. You must reimport the pull request before landing.
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@hx235 merged this pull request in facebook/rocksdb@aec15eebec08429142fde04a4006303412def90c.
Context/Summary:
Error in
BlockCacheLookupForReadAheadSize()
is not critical enough to return such error in read path. That's because the worst case is to not have any read ahead. See below comment. https://github.com/facebook/rocksdb/blob/a31fe521732c6150003ea43f1e30f27f13be597c/table/block_based/block_based_table_iterator.cc#L867-L871Therefore we should allow the read to return ok() even when we inject read error there.
Test: Below command failed with
Didn't get expected error from PrefixScan
before the fix but passes after