search

facebook / rocksdb

A library that provides an embeddable, persistent key-value store for fast storage.
http://rocksdb.org
GNU General Public License v2.0
27.83k stars 6.2k forks source link

Fix CondVar::TimedWait for Windows #12815

Open eniac1024 opened 1 week ago

eniac1024 commented 1 week ago

Based on https://github.com/microsoft/STL/issues/369 They fixed the issue in std::condition_variable_any but not in std::condition_variable, which is currently used in rocksdb repo. So we need to implement the work around regardless of _MSVC_STL_UPDATE.

facebook-github-bot commented 1 week ago

Hi @eniac1024!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 1 week ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

eniac1024 commented 2 days ago

What does "for vs2019" mean in the title? The description and code appear to generalize the workaround to non-vs2019.

You're right, it's a generalized workaround, and the title was confusing. This issue started when compiling with VS2019 (which upticked the STL version). Everything was working fine with previous VS version.