Closed hx235 closed 3 days ago
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@hx235 has updated the pull request. You must reimport the pull request before landing.
@hx235 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@hx235 merged this pull request in facebook/rocksdb@c7e94bc878013b80a4288c5ddf5344a8e21d668e.
Context/Summary:
Right now we need to persist WAL data before closing for reopen when
reopen > 0
anddisable_wal = false
https://github.com/facebook/rocksdb/blame/71f9e6b5b36e3223e8dba29df75e4e5008818d16/db_stress_tool/db_stress_test_base.cc#L3479. Previous injected WAL write errors may not be cleared by the time of closing and ready or persisting WAL. To simplify, we disable any WAL write error injection whenreopen > 0
anddisable_wal = false
Test: Below command failed
Error persisting WAL data which is needed before reopening the DB: IO error: Writer has previous injected error.
with but passes after we disable WAL write error injection (exclude_wal_from_write_fault_injection=1, metadata_write_fault_one_in=0)