search

facebook / sapling

A Scalable, User-Friendly Source Control System.
https://sapling-scm.com
GNU General Public License v2.0
6.19k stars 285 forks source link

Should smartlog hide already closed pull requests? #364

Open discentem opened 1 year ago

discentem commented 1 year ago

This might be a problem specific to repos like facebook/sapling given PRs don't actually get merged and instead just imported. I'm not 100% sure 🤔

zzl0 commented 1 year ago

Hi @discentem, thanks for posting the issue.

For "closed" PRs, I assume you mean "closed" but not "merged" PRs.

Currently, the auto-hide logic only hides merged PRs. The reason why we don't auto-hide closed PRs is that a PR can be closed by maintainers of the upstream repo and the author of the PR may still want to see the PR commits in their smartlog.

If you want to hide closed PRs in smartlog, you need to use 'sl hide' to hide the closed commits for now.

We could use a config to allow users to enable auto-hide logic for closed PRs in the future.