search

facebook / sapling

A Scalable, User-Friendly Source Control System.
https://sapling-scm.com
GNU General Public License v2.0
6.14k stars 283 forks source link

Cannot submit PR to repo fork with Issues enabled #373

Open sgianelli opened 1 year ago

sgianelli commented 1 year ago

I forked a repo that had Issues disabled so I could play around with sapling and enabled Issues on the fork, but when I run sl pr submit it always returns:

abort: Error while trying to create a placeholder issue for a pull request on common-room/sparta: {
 "message": "Issues are disabled for this repo",
 "documentation_url": "https://docs.github.com/v3/issues/"
}

Some online discussion unrelated to sapling indicates that toggling Issues off and on in settings should fix the problem but that does not seem to work which makes me wonder if its an issue related to sapling.

Somewhat related to #371

sgianelli commented 1 year ago

Ahh yeah it appears to be an issue with the upstream repo not having Issues enabled. If I enable Issues on the repo that I forked off of, then sl pr submit works, regardless of the setting for the forked repo.

sgianelli commented 1 year ago

Wait no I lied. Sort of. It created a PR against the original repo even though I cloned the forked repository. This seems like unexpected behavior unless the expectation is that it submits a pull request from the forked repo against the original repo which maybe makes all of this make more sense.