search

facebook / sapling

A Scalable, User-Friendly Source Control System.
https://sapling-scm.com
GNU General Public License v2.0
6.13k stars 280 forks source link

VSCode Extension - Commit details shows inverted diff #634

Closed murtlatif closed 1 year ago

murtlatif commented 1 year ago

In the VSCode extension, when selecting Open diff view in the Commit info section, it opens the diff in the reverse order (i.e. the commit changes are the "old"/"prev" changes rather than the "current"/"new" changes.

The only exception for this is if you are currently checked out at the commit you are viewing the diff for. In this case, it looks like it presents the diff view correctly.

RichardCPoint commented 1 year ago

I see this too in Sapling 0.2.20230523-092610+f12b7eee.

Curiously, the diff view is correct when looking at the currently checked-out commit, but is reversed for any other commit.

alex-statsig commented 1 year ago

I put up https://github.com/facebook/sapling/pull/637 to fix this, just waiting on a review

murtlatif commented 1 year ago

Curiously, the diff view is correct when looking at the currently checked-out commit, but is reversed for any other commit.

I do experience the same thing, and I updated the issue description as well to include this

alex-statsig commented 1 year ago

@sggutier (or others capable of merging in open source changes?), could review of https://github.com/facebook/sapling/pull/637 be prioritized? It's been waiting around for a month

sggutier commented 1 year ago

@alex-statsig sorry for the delay. I just imported your request a few minutes ago