facebook / sapling

A Scalable, User-Friendly Source Control System.
https://sapling-scm.com
GNU General Public License v2.0
6.14k stars 283 forks source link

Naming of Git branches for PRs #642

Open RichardCPoint opened 1 year ago

RichardCPoint commented 1 year ago

Currently when creating a Github PR using Sapling, the name of the branch is always of the form pr12345 – there doesn't seem to be any way to change this (besides manually creating PRs).

I've had feedback from coworkers that this is confusing to them when they review my PRs.

Is there any way that this could be made configurable, for example via an extra parameter to sl pr submit, or ideally with a configurable string-replacement pattern based on the commit title?

sggutier commented 1 year ago

There is a way of pushing to some specific branch (and creating it) with sl push --to "my-branch-name". For local development, instead of branches you can use bookmarks.

Does sl push --to do what you would expect it to? If so, we can make this feature more visible / user friendly

RichardCPoint commented 1 year ago

There is a way of pushing to some specific branch (and creating it) with sl push --to "my-branch-name". For local development, instead of branches you can use bookmarks.

Certainly it works to use bookmarks to create branches on Github, but I would need to create and manage the PRs manually, which would lose some of the benefits of Sapling.