search

facebook / sapling

A Scalable, User-Friendly Source Control System.
https://sapling-scm.com
GNU General Public License v2.0
6.06k stars 273 forks source link

[ReviewStack] Sticky footer #645

Open equetzal opened 1 year ago

equetzal commented 1 year ago

Problem

When accesing (ReviewStack](https://reviewstack.dev) for the first time, there's a footer that is sticky:

Captura de pantalla 2023-06-02 a la(s) 7 21 48 a m

Expected behavior

Not sure if that is intentionally, but I would expect it not to be sticky but be at the bottom of the scroll. Let me know if I'm wrong.

I tried to fix this by myself but I couldn't make ReviewStack to run due to missing modules problems on the codegen. Not sure if I missed some documentation on how to build it.

sggutier commented 1 year ago

I've seen the codegen issues myself sometimes. Have you tried building it with node v18 or older? Also, sorry for not having build instructions at the moment. You could take a look at what the CI does for building it as a workaround:

https://github.com/facebook/sapling/blob/main/.github/workflows/reviewstack.dev-deploy.yml