search

facebook / sapling

A Scalable, User-Friendly Source Control System.
https://sapling-scm.com
GNU General Public License v2.0
6.1k stars 279 forks source link

ISL: Show tag for PR "follower" commits #877

Closed rejc2 closed 5 months ago

rejc2 commented 5 months ago

ISL: Show a tag for PR "follower" commits (i.e. after running sl pr follow -r . on a commit).

image

Currently the sl smartlog shows this, but not the interactive smartlog:

image
facebook-github-bot commented 5 months ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

evangrayk commented 5 months ago

Thanks for the PR!

We've been talking about improving the GitHub PR experience. I think making it easier to have multiple commits per PR would be nice, since that's how GitHub works best. I imagine we'll improve this part of the flow as part of that. In the mean time, I think it makes sense to add this given the CLI shows the follower status already.

I think the "Follower" tag works fine on the CLI, but it's maybe a little clunky in the full UI. We can improve that in the future though.

facebook-github-bot commented 5 months ago

This pull request has been merged in facebook/sapling@09155324f9da7196b9d37981d2f690f594f79fb8.