search

facebook / sapling

A Scalable, User-Friendly Source Control System.
https://sapling-scm.com
GNU General Public License v2.0
6.1k stars 279 forks source link

[sl] github: refactor create_pull_request_title_and_body() #902

Closed zzl0 closed 3 months ago

zzl0 commented 3 months ago

[sl] github: refactor create_pull_request_title_and_body()

Summary:

This diff makes create_pull_request_title_and_body() have one parameter that has to be either commit_msg: str or (title, body): Tuple[str, str].

Test Plan:

./run-tests.py test-ext-github-ghrevset.t test-ext-github-pr-submit-closed.t test-ext-github-pr-submit-overlap.t test-ext-github-pr-submit-placeholder-issue.t test-ext-github-pr-submit-single.t
...
----------------------------------------------------------------------
# Ran 5 tests, 0 skipped, 0 failed.
facebook-github-bot commented 3 months ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 3 months ago

@zzl0 merged this pull request in facebook/sapling@9758373efb5e4d99a713a8c293ab1fe412400aa8.