Open zjijz opened 3 weeks ago
Based on the output of sl
, it does not appear that Sapling knows anything about the relationship between your commit and a GitHub PR. If it did, you would see #123
after the commit title.
This was for commit bcc265a08
, which has #13
after it. I just pasted the entire sl
tree, but it's just referencing the bottom commit.
@zjijz what if you use -r
explicitly: sl unlink -r bcc265a08
?
Though I admit the docs for sl pr unlink
imply it should operate on the current commit by default.
That was it! sl pr unlink -r .
worked.
Can I make a request that pr unlink
is updated to work implicitly with the current commit like pr submit
or that a warning is added if there is no implicit default commit and sl pr unlink
is called with no commit hashes?
I was suggested to use
sl pr unlink
when trying to runsl pr submit
when the associated GitHub PR had already been closed. I then attempted that, but it didn't seem to change thesl
state at all.This was on the macOS version installed by
brew
.This was the latest version available through
brew
(previously calledbrew upgrade sapling
).sl
,sl pr unlink
,sl
(on the base commitbcc265a08
):sl pr submit
still fails after this with the same error as before and offers the same guidance to usesl pr unlink
.I tried installing
sl
frombrew
at--HEAD
, but that version is giving me issues: