search

facebook / sapling

A Scalable, User-Friendly Source Control System.
https://sapling-scm.com
GNU General Public License v2.0
6.18k stars 285 forks source link

bug 🐛: every sl command crashes with "unknown python exception" #960

Closed vegerot closed 2 weeks ago

vegerot commented 1 month ago

(almost) Every sl command I run gives the same error message:

$ sl
unknown python exception

$ sl show
unknown python exception

$ sl --version
Sapling 4.4.2_20240930_132004_4a1d4f6f8e0d
(see https://sapling-scm.com/ for more information)

$ CHGDISABLE=1 sl
unknown python exception

I bisected Sapling and found the culprit: 4a1d4f6f8e0de7b33ea060161e0c4d19e6178112 I can confirm that Python 3.11 works fine but 3.12 💥

This is on macOS 14.7 and Python 3.12.6 from homebrew

vegerot commented 1 month ago

(tagging #957)

ahornby commented 1 month ago

https://github.com/facebook/sapling/pull/964 might help. I got the tests up and running and then used them to validate 3.12 on Ubuntu 24.04

markbhasawut commented 3 weeks ago

This issue should be fixed by commit 65a7e9097fb9280aef7c50ecdf08b5755288490a. I was able to run sl commands on macOS with Python 3.12.7 and successfully validated the tests without any exceptions.

vegerot commented 2 weeks ago

@markbhasawut Confirmed! Thanks