search

facebook / sapling

A Scalable, User-Friendly Source Control System.
https://sapling-scm.com
GNU General Public License v2.0
6.18k stars 285 forks source link

sl pr submit doesn't use the bookmark name #970

Open hakanalpaydd opened 4 weeks ago

hakanalpaydd commented 4 weeks ago

Using VS Code Interactive Smartlog

  1. be checked out on master

  2. make changes

  3. Commit changes with some name

    image

  4. Right click on the commit and create bookmark (to give it a branch name for when the PR is pushed to github)

    image

  5. Observe bookmark name is added

    image

  6. Submit for code review. This button runs sl pr submit

    image

  7. Observe that bookmark (branch name) not used in PR

    image

Is there a way to fix this? Either with commands or in the UI (ideally both)?