get mononoke green in github CI

ahornby commented 4 weeks ago

Summary:

mononoke unit tests are failing, fix them
test-cross-repo-mononoke-git-sot.t deleted, remove from exclusion list

changes done to make this easier:

python-click wasn't found in sapling dir, added package mappings for rpm and deb so that we can pick up the installed version
add a bit more info to the "unknown python exception" message from hg
reduce paths set by getdeps, no point listing non-existing dir, makes it easier to see what is happening

Test Plan:

Local run of unittest

./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. mononoke
./build/fbcode_builder/getdeps.py --allow-system-packages test--src-dir=. mononoke

Before fails:

failures:
    store::test::test_find_abandoned_requests
    store::test::test_get_stats
    store::test::test_mark_as_new

After, passes.

Local run of integration test

# first build sapling cli & install system deps
./build/fbcode_builder/getdeps.py --allow-system-packages build --src-dir=. sapling
./build/fbcode_builder/getdeps.py install-system-deps --recursive mononoke_integration
# then test mononoke
./build/fbcode_builder/getdeps.py --allow-system-packages build --no-deps --src-dir=. mononoke_integration
./build/fbcode_builder/getdeps.py --allow-system-packages test --src-dir=. mononoke_integration --num-jobs=4

Before, fails

AssertionError: The test groups contain not existing tests: ['cross_repo/test-cross-repo-mononoke-git-sot-switch.t'] in /home/runner/work/sapling/sapling/eden/mononoke/tests/integration

After, passes

facebook-github-bot commented 4 weeks ago

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.